Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clarity to ADR 043 nft data field #9388

Merged
merged 2 commits into from
May 26, 2021
Merged

Adding clarity to ADR 043 nft data field #9388

merged 2 commits into from
May 26, 2021

Conversation

shahankhatch
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added T: ADR An issue or PR relating to an architectural decision record T:Docs Changes and features related to documentation. labels May 25, 2021
alexanderbez
alexanderbez approved these changes May 25, 2021
View reviewed changes
docs/architecture/adr-043-nft-module.md Outdated Show resolved Hide resolved
@shahankhatch @alexanderbez
Update docs/architecture/adr-043-nft-module.md
7feabee 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@shahankhatch
Copy link
Contributor Author

Related to #9329

chengwenxi
chengwenxi approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@chengwenxi chengwenxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your detailed description, can I merge it?

@chengwenxi chengwenxi merged commit 1f3ec2a into hulatown/adr-043-nft May 26, 2021
@chengwenxi chengwenxi deleted the shahan/adr-043_nft_data_field branch May 26, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@chengwenxi chengwenxi chengwenxi approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
T: ADR An issue or PR relating to an architectural decision record T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahankhatch @alexanderbez @chengwenxi